26.04 Cert Suite updates (New)#2474
Conversation
Creates 24.04 versioned launchers and test plans Creates 26.04 versioned launchers and test plans Updates 26.04 plans with additional tests and blocking/non-blocking status otehr minor fixes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2474 +/- ##
=======================================
Coverage 58.87% 58.87%
=======================================
Files 476 476
Lines 48004 48004
Branches 8568 8568
=======================================
Hits 28260 28260
+ Misses 18853 18850 -3
- Partials 891 894 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds versioned (24.04/26.04) certification-server launchers and test plans, updating the default “certify” launchers to point at the new 26.04 plans.
Changes:
- Versioned server/VM/SOC test plan units added for 24.04 and/or 26.04; legacy
server-fullremoved. - New 24.04/26.04 launcher entries added; default server/VM/SOC launchers updated to 26.04 units.
- Base info test plan extended with additional system/network/kernel inventory attachments.
Reviewed changes
Copilot reviewed 15 out of 18 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| providers/certification-server/units/virtual-machine-full.pxu | Renames unit id to a 24.04-specific VM plan id. |
| providers/certification-server/units/virtual-machine-full-26.04.pxu | Adds a 26.04 VM full plan with blocker/non-blocker classifications. |
| providers/certification-server/units/server-soc-cert-26.04.pxu | Adds a 26.04 server SoC-focused test plan. |
| providers/certification-server/units/server-functional-26.04.pxu | Adds a 26.04 “functional-only” server test plan. |
| providers/certification-server/units/server-full.pxu | Removes the unversioned server-full plan. |
| providers/certification-server/units/server-full-26.04.pxu | Adds a 26.04 versioned server-full plan. |
| providers/certification-server/units/server-full-24.04.pxu | Adds a 24.04 versioned server-full plan. |
| providers/certification-server/launcher/test-functional-26.04 | Adds a launcher for the 26.04 functional-only plan. |
| providers/certification-server/launcher/certify-vm-24.04 | Adds a launcher for the 24.04 VM plan. |
| providers/certification-server/launcher/certify-ubuntu-server-vm | Updates default VM launcher to 26.04 VM plan. |
| providers/certification-server/launcher/certify-ubuntu-server-soc | Updates default SoC launcher to new 26.04 SoC plan id. |
| providers/certification-server/launcher/certify-ubuntu-server | Updates default server launcher to 26.04 server-full plan. |
| providers/certification-server/launcher/certify-soc-24.04 | Adds a 24.04 SoC launcher (currently points to unversioned unit). |
| providers/certification-server/launcher/certify-24.04 | Adds a launcher for the 24.04 server-full plan. |
| providers/base/units/info/test-plan.pxu | Adds kernel/network/SR-IOV inventory and lspci attachment to info plan. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 18 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e times. What am I doing in Git causing these to disappear?
|
I've tested these on a vm and all of the launchers launch tests and everything seems to work even with the minor issues copilot complained about, but I've also fixed all those issues (tabs instead of spaces, thanks to not having my vimrc copied over, the missing spaces in the id: filed in a couple places, etc). |
Description
Creates 24.04 versioned launchers and test plans
Creates 26.04 versioned launchers and test plans
Updates 26.04 plans with additional tests and blocking/non-blocking status
other minor fixes
Resolved issues
Resolves SERVCERT-2031
Documentation
Docs will follow along later. There are no substantive docs relevant changes anyway, we are just adding the launcher for 26.04 testing, functionally it behaves exactly as already documented.
Tests
provider changes validated with manage.py in a venv.