Siblings handling wrong in YAML units (bugfix)#2496
Merged
Conversation
Siblings were wrongly assumed to be a string, therefore passed into the _leaf function that only handles strings
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2496 +/- ##
==========================================
+ Coverage 58.92% 58.93% +0.01%
==========================================
Files 476 476
Lines 48022 48037 +15
Branches 8570 8576 +6
==========================================
+ Hits 28297 28312 +15
Misses 18833 18833
Partials 892 892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Minor: black formatting
Hook25
force-pushed
the
siblings_handling_wrong
branch
from
cec0dc2 to
5211c00
Compare
pieqq
approved these changes
Apr 23, 2026
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Thanks for updating the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Siblings were wrongly assumed to be a string, therefore passed into the _leaf function that only handles strings. Also, the other assert was wrongly assuming the values passed in would only be single keys, but that is not true for siblings.
Resolved issues
Discovered while working on: https://warthogs.atlassian.net/browse/CHECKBOX-2200
Documentation
N/A
Tests
Added unit tests