Skip to content

Copy sibling fields to avoid changing parent unit (bugfix)#2497

Merged
Hook25 merged 1 commit into
mainfrom
fix_siblings_parent
Apr 22, 2026
Merged

Copy sibling fields to avoid changing parent unit (bugfix)#2497
Hook25 merged 1 commit into
mainfrom
fix_siblings_parent

Conversation

@Hook25
Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 commented Apr 22, 2026

Description

Not copying is alway wrong here. It worked before because all mutations that we were doing were over string, which are immutable, so they automatically would copy. This leads to a funny bugs like flags of the parent unit being modified when sibiling unit is modified.

Resolved issues

Discovered while working on: https://warthogs.atlassian.net/browse/CHECKBOX-2200

Documentation

N/A

Tests

N/A (Change is really small, I don't even know how to test it)

This would lead to funny bugs like flags of the parent unit being
modified when sibiling unit is modified
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.92%. Comparing base (475d7e7) to head (4516742).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2497      +/-   ##
==========================================
- Coverage   58.92%   58.92%   -0.01%     
==========================================
  Files         476      476              
  Lines       48027    48025       -2     
  Branches     8571     8571              
==========================================
- Hits        28302    28300       -2     
  Misses      18833    18833              
  Partials      892      892              
Flag Coverage Δ
checkbox-ng 76.06% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hook25 Hook25 merged commit aed87f5 into main Apr 22, 2026
39 checks passed
@Hook25 Hook25 deleted the fix_siblings_parent branch April 22, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants