Copy sibling fields to avoid changing parent unit (bugfix)#2497
Merged
Conversation
This would lead to funny bugs like flags of the parent unit being modified when sibiling unit is modified
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2497 +/- ##
==========================================
- Coverage 58.92% 58.92% -0.01%
==========================================
Files 476 476
Lines 48027 48025 -2
Branches 8571 8571
==========================================
- Hits 28302 28300 -2
Misses 18833 18833
Partials 892 892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pieqq
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Not copying is alway wrong here. It worked before because all mutations that we were doing were over string, which are immutable, so they automatically would copy. This leads to a funny bugs like flags of the parent unit being modified when sibiling unit is modified.
Resolved issues
Discovered while working on: https://warthogs.atlassian.net/browse/CHECKBOX-2200
Documentation
N/A
Tests
N/A (Change is really small, I don't even know how to test it)