Skip to content

Stop lstopo from hanging in 26.04 (BugFix)#2520

Merged
Hook25 merged 4 commits into
mainfrom
fix-lstopo
May 6, 2026
Merged

Stop lstopo from hanging in 26.04 (BugFix)#2520
Hook25 merged 4 commits into
mainfrom
fix-lstopo

Conversation

@tomli380576
Copy link
Copy Markdown
Contributor

@tomli380576 tomli380576 commented May 6, 2026

WARNING: This modifies com.canonical.certification::sru-server

Description

A quick 1-line fix to stop lstopo from hanging forever. The solution comes from here open-mpi/ompi#13838 (comment).

This PR also changes lstopo to lstopo-no-graphics as discussed in the office hours.

Resolved issues

lstopo hanging in 26.04

Documentation

open-mpi/hwloc#517

Tests

Ran HWLOC_COMPONENTS=-gl lstopo-no-graphics in 16.04~26.04 and they all successfully finish.

https://certification.canonical.com/hardware/201812-26713/submission/486967/

@tomli380576 tomli380576 changed the title Stop lstopo from hanging (BugFix) Stop lstopo from hanging in 26.04 (BugFix) May 6, 2026
@tomli380576 tomli380576 requested a review from Copilot May 6, 2026 02:16
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.92%. Comparing base (a9d93d2) to head (e3d6e0b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2520   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files         476      476           
  Lines       48033    48033           
  Branches     8575     8575           
=======================================
  Hits        28305    28305           
+ Misses      18835    18832    -3     
- Partials      893      896    +3     
Flag Coverage Δ
provider-base 34.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the base “info” attachment job that captures hardware topology to avoid lstopo hanging on Ubuntu 26.04 by switching to a non-graphics invocation and disabling the gl hwloc component.

Changes:

  • Update the topology attachment command to run HWLOC_COMPONENTS=-gl lstopo-no-graphics instead of lstopo -v.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread providers/base/units/info/jobs.pxu Outdated
Comment thread providers/base/units/info/jobs.pxu Outdated
@tomli380576 tomli380576 marked this pull request as ready for review May 6, 2026 03:14
@Hook25 Hook25 merged commit 7a8552d into main May 6, 2026
31 of 32 checks passed
@Hook25 Hook25 deleted the fix-lstopo branch May 6, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants