Skip to content

fix: Update ethernet/multi_iperf3_nic_device job to avoid virtual devices (BugFix)#2534

Open
ajzobro wants to merge 1 commit into
mainfrom
fix/skip-iperf3-for-virtual-ethernet
Open

fix: Update ethernet/multi_iperf3_nic_device job to avoid virtual devices (BugFix)#2534
ajzobro wants to merge 1 commit into
mainfrom
fix/skip-iperf3-for-virtual-ethernet

Conversation

@ajzobro
Copy link
Copy Markdown

@ajzobro ajzobro commented May 20, 2026

Description

Updated the filter used by the ethernet/multi_iperf3_nic_device... job to avoid attempting to do iperf3 testing of virtual ethernet devices, which are typically used for administration of servers.

As seen in https://certification.canonical.com/certificates/request/2605-17514/

Resolved issues

See above.

Documentation

N/A

Tests

Not tested

…id attempting to test with virtual ethernet devices, which are typically used for administration of servers
@ajzobro ajzobro marked this pull request as draft May 20, 2026 21:48
@ajzobro ajzobro requested a review from Copilot May 20, 2026 21:48
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.92%. Comparing base (a9d93d2) to head (ef8c208).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2534   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files         476      476           
  Lines       48033    48033           
  Branches     8575     8575           
=======================================
  Hits        28305    28305           
+ Misses      18835    18832    -3     
- Partials      893      896    +3     
Flag Coverage Δ
provider-base 34.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Checkbox base provider’s ethernet Multi-NIC iperf3 template selection to skip a known virtual NIC type, reducing false failures when administrative/virtual interfaces are present on server systems.

Changes:

  • Narrowed the ethernet/multi_iperf3_nic_device... template resource filter to exclude devices with product_slug == 'Virtual_Ethernet_'.

@ajzobro ajzobro marked this pull request as ready for review May 20, 2026 22:33
@ajzobro ajzobro requested review from Hook25 and rodwsmith May 20, 2026 22:33
Copy link
Copy Markdown
Collaborator

@rodwsmith rodwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable on its face, but I would like some checks that this change won't introduce any false positives on the device.product_slug != 'Virtual_Ethernet_' test -- that is, that it won't accidentally exclude something it shouldn't. Maybe write a script to pull down a bunch of submissions (both server and device; say, 100+ submissions of each), check to see if this condition would be met, and then hand-verify that it's all OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants