Upgrade with effective coverage tips #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieqq
requested changes
Aug 25, 2023
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Sensible explanation. A few typos/suggestions below, and then it can land :)
Thanks!
pieqq
approved these changes
Sep 4, 2023
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
All good! Thanks! (and thanks for updating the PR template as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The contributing documentation does not provide examples as to why we would consider an acceptable way to go about coverage. This adds a paragraph with a practical example on how we think and work towards/with covering 100% of the codebase.
Resolved issues
Resolves: https://warthogs.atlassian.net/browse/CHECKBOX-799
Documentation
N/A
Tests
N/A