Skip to content

Conversation

@rkratky
Copy link

@rkratky rkratky commented Nov 14, 2025

  • Starter Pack update
  • Content update

@rkratky rkratky force-pushed the update-sp branch 5 times, most recently from bc42aad to b9fa298 Compare November 14, 2025 13:01
@asanvaq asanvaq marked this pull request as draft November 17, 2025 09:01
@rkratky rkratky marked this pull request as ready for review November 22, 2025 17:20
@rkratky
Copy link
Author

rkratky commented Nov 22, 2025

@asanvaq, apologies for the delay. This is now ready for review & merging.

@asanvaq asanvaq requested a review from cjdcordeiro November 24, 2025 08:36
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I'm afraid we can't merge this as is. Here are a few notes:

  1. this is applying changes way beyond the scope of the starter pack (51 files changed 🤯 )
  2. some of these changes are actually touching the contents of the docs, including removing things like the checklist of the "how to slice a package" guide, or rephrasing contents of the security reference
  3. it also changes significantly the meta tags of the resulting docs (conf.py), which is something that should be reviewed in separate
  4. it is removing and adding CI workflows. This would've been kind of acceptable if the changes were associated with the update of the starter pack, but some don't seem to be. E.g. the cla-check is needed, but unrelated to this PR; the markdown-style-checks and check-removed-urls add useful jobs, but seem like a boilerplate copy of a bunch of steps that may be equal for many other doc pages - thus these should instead be using reusable workflows (like the automatic-doc-checks instead of duplicating steps which will soon be outdated and requiring constant maintenance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants