Merged
Conversation
openEuler Homepage: https://www.openeuler.org/en/ Signed-off-by: zhuzaifangxuele <zhuzaifangxuele.gmail.com>
fix line too long Signed-off-by: zhuzaifangxuele <zhuzaifangxuele.gmail.com>
…d-init into support-openEulerOS
zhuzaifangxuele
force-pushed
the
support-openEulerOS
branch
from
1fd61c9 to
9153d55
Compare
…d-init into support-openEulerOS
TheRealFalcon
suggested changes
Sep 9, 2021
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I left some small comments inline, but otherwise looks good.
cloudinit/distros/openEuler.py
Outdated
| @@ -0,0 +1,10 @@ | |||
| from cloudinit.distros import rhel | |||
Contributor
There was a problem hiding this comment.
Can we add a # This file is part of cloud-init. See LICENSE file for license information. at the top?
cloudinit/distros/openEuler.py
Outdated
| from cloudinit.distros import rhel | ||
| from cloudinit import log as logging | ||
|
|
||
| LOG = logging.getLogger(__name__) |
Contributor
There was a problem hiding this comment.
LOG (and it's import) isn't used, so let's get rid of it.
Contributor
Author
There was a problem hiding this comment.
ok, i hava done
added 2 commits
September 10, 2021 11:02
…d-init into support-openEulerOS
abandon not used 'LOG' add license information at top of file Signed-off-by: zhuzaifangxuele <zhuzaifangxuele.gmail.com>
This was referenced May 12, 2023
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
www.openeuler.org
Signed-off-by: zhuzaifangxuele <zhuzaifangxuele.gmail.com>
Checklist: