Skip to content

make suse and sles support 127.0.1.1#336

Merged
blackboxsw merged 2 commits intocanonical:masterfrom
chengcheng-chcheng:suse_sles_127.0.1.1
May 7, 2020
Merged

make suse and sles support 127.0.1.1#336
blackboxsw merged 2 commits intocanonical:masterfrom
chengcheng-chcheng:suse_sles_127.0.1.1

Conversation

@chengcheng-chcheng
Copy link
Copy Markdown
Contributor

Same as ubuntu-debian as link below, make sles-suse also support 127.0.1.1
http://www.leonardoborda.com/blog/127-0-1-1-ubuntu-debian/

Tested on the local sles, changed the local hosts.suse.tmpl and opensuse.py files and then changed the hostname or set the static ip, the 127.0.1.1 was set in the /etc/hosts

@blackboxsw
Copy link
Copy Markdown
Collaborator

Thanks for the PR submittal @chengcheng-chcheng
Cloud-init is governed by a contributor license agreement.

Would you be able to submit the CLA so we can merge this commit of yours into cloud-init upstream?

Details are below.
https://cloudinit.readthedocs.io/en/latest/topics/hacking.html#do-these-things-once

@blackboxsw blackboxsw self-assigned this Apr 30, 2020
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we'll need a CLA signed in order to accept this patch upstream please.

@chengcheng-chcheng
Copy link
Copy Markdown
Contributor Author

chengcheng-chcheng commented May 6, 2020

Looks good, but we'll need a CLA signed in order to accept this patch upstream please.

For the Transferring CLA Signatures , post review here:
#356

Copy link
Copy Markdown
Contributor

@rjschwei rjschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackboxsw
Copy link
Copy Markdown
Collaborator

Thanks for this PR @chengcheng-chcheng and for signing the CLA for cloud-init to contribute this. Again the branch looks good and I can confirm that that localhost IP change is valid on local opensuse containers I launch. I've asked for a look from a OpenSUSE mantainer to make sure.

@blackboxsw blackboxsw merged commit b24b376 into canonical:master May 7, 2020
@chengcheng-chcheng chengcheng-chcheng deleted the suse_sles_127.0.1.1 branch June 3, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants