cc_snap: validate that assertions property values are strings#370
Merged
OddBloke merged 3 commits intocanonical:masterfrom May 21, 2020
Merged
cc_snap: validate that assertions property values are strings#370OddBloke merged 3 commits intocanonical:masterfrom
OddBloke merged 3 commits intocanonical:masterfrom
Conversation
blackboxsw
approved these changes
May 19, 2020
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
+1 and I think we can now drop
the comment at the top of cc_snap right?
# TODO schema for 'assertions' and 'commands' are too permissive at the moment.
# Once python-jsonschema supports schema draft 6 add support for arbitrary
# object keys with 'patternProperties' constraint to validate string values.
TheRealFalcon
approved these changes
May 20, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And add an example of providing a list of assertions.