enable Puppet, Chef mcollective in default config#385
Merged
raharper merged 2 commits intocanonical:masterfrom May 27, 2020
Merged
enable Puppet, Chef mcollective in default config#385raharper merged 2 commits intocanonical:masterfrom
raharper merged 2 commits intocanonical:masterfrom
Conversation
Collaborator
|
Thanks Mina! I have no objection to this change, it seems like the right thing to do. If there are issues with the config modules then we can address those. I do have one outstanding concern though: if these modules are so broken on *BSD that they traceback during in their default behaviour, then this will regress boot on *BSD. Can you confirm that you've successfully booted a BSD image with these modules reenabled? |
Collaborator
Author
|
without configuration so far: |
these config management things work on BSD, they also claim to work on all distros, so enabling them! ref: https://bugs.launchpad.net/cloud-init/+bug/1880279
Collaborator
|
Hrm, Travis shows green but it's "waiting for status here" |
raharper
approved these changes
May 27, 2020
Collaborator
raharper
left a comment
There was a problem hiding this comment.
This looks good to me.
Merged
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these config management things work on BSD, they also claim to work on all distros, so enabling them!
ref: https://bugs.launchpad.net/cloud-init/+bug/1880279