docs: align users-groups example YAMLs with comment text#6865
Closed
0xdeadd wants to merge 1 commit intocanonical:mainfrom
Closed
docs: align users-groups example YAMLs with comment text#68650xdeadd wants to merge 1 commit intocanonical:mainfrom
0xdeadd wants to merge 1 commit intocanonical:mainfrom
Conversation
Examples 3 and 4 in the cc_users_groups module docs describe behavior (password-based login rejected, SSH access for the GitHub user TheRealFalcon and the Launchpad user falcojr) that the actual YAML examples didn't include. Add the missing lock_passwd and ssh_import_id fields so the rendered example matches the prose. Inline-array syntax for ssh_import_id matches the existing convention in cc_ssh_import_id/example1.yaml and cc_users_groups/example7.yaml. Fixes canonicalGH-6857
Collaborator
|
thank you for the submission @0xdeadd. I believe we already have a pull request in progress that is attempting to address this fix in #6858. If there is something else not covered in that pull request please feel free to comment on that PR instead. I'll close this PR in the meantime while we await resolution and merge of the prior PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Summary
The example3 and example4 comments in
doc/module-docs/cc_users_groups/data.yamldescribe two behaviors that are missing from the corresponding YAML files:lock_passwd: truewas absentTheRealFalconand the Launchpad userfalcojrcan SSH asnewsuper" →ssh_import_idwas absentThis PR adds the two fields to both example3.yaml and example4.yaml so the rendered docs match the prose.
Test Plan
Checklist
Fixes #6857