Skip to content

Azure: Retry dhcp on timeouts when polling reprovisiondata in the nic attach path#998

Merged
TheRealFalcon merged 1 commit intocanonical:mainfrom
aswinrajamannar:retrydhcp
Aug 24, 2021
Merged

Azure: Retry dhcp on timeouts when polling reprovisiondata in the nic attach path#998
TheRealFalcon merged 1 commit intocanonical:mainfrom
aswinrajamannar:retrydhcp

Conversation

@aswinrajamannar
Copy link
Contributor

@aswinrajamannar aswinrajamannar commented Aug 24, 2021

Proposed Commit Message

Azure: Retry dhcp on timeouts when polling reprovisiondata in the nic attach path

In the nic attach path, we skip doing dhcp since we already did it when bringing the interface up.

However when polling for reprovisiondata, it is possible for the request to timeout due to platform issues.

In those cases we still need to do dhcp and try again since we tear down the context. We can only skip the first dhcp attempt.

Test Steps

  • Create savable PPS VMs (internal to Azure)
  • Reuse the PPS VM to exercise the nic hot attach path
  • In rare cases, the first attempt to get reprovisiondata might timeout. Without this fix, cloud-init would tear down the dhcp and all retry attempts since then would fail with network unreachable error. With this fix, dhcp is retried and the polling continues.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants