Fix consul-client logging and socket timeout#32
Merged
ahmad-can merged 1 commit intocanonical:mainfrom Mar 10, 2026
Merged
Conversation
ahmad-can
force-pushed
the
log-rotate
branch
2 times, most recently
from
e0e2b06 to
a081d2f
Compare
gboutry
reviewed
Mar 10, 2026
Collaborator
gboutry
left a comment
gboutry
left a comment
There was a problem hiding this comment.
Are the emojis really necessary?
The current logger keeps adding logs to the file and the file grows infinitely. Introduce Time based rotating logs and keep only 3 days of log backup LP 2143804
Collaborator
Author
removed emojis |
gboutry
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logger keeps adding logs to the file and the file grows infinitely. Introduce Time based rotating logs and keep only 3 days of log backup LP 2143804