extra-file: make /etc/systemd/journald.conf.d writable#109
Merged
mvo5 merged 1 commit intocanonical:masterfrom Oct 24, 2019
Merged
extra-file: make /etc/systemd/journald.conf.d writable#109mvo5 merged 1 commit intocanonical:masterfrom
mvo5 merged 1 commit intocanonical:masterfrom
Conversation
This is a useful property on its own but its also important to get https://github.com/snapcore/snapd/pull/7605/files fixed.
zyga
approved these changes
Oct 24, 2019
Contributor
zyga
left a comment
zyga
left a comment
There was a problem hiding this comment.
LGTM
Please either update it yourself or ping me to update snapd's tests/main/mount-ns test for core16 (currently disabled in the backend) to compensate.
anonymouse64
approved these changes
Oct 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a useful property on its own but its also important to get
https://github.com/snapcore/snapd/pull/7605/files fixed.