Skip to content

Comments

live-build/hooks: add chroot hook to rm cloud-init config file we don't want#115

Merged
mvo5 merged 1 commit intocanonical:masterfrom
anonymouse64:feature/rm-cloud-init-unneeded-config
Aug 6, 2020
Merged

live-build/hooks: add chroot hook to rm cloud-init config file we don't want#115
mvo5 merged 1 commit intocanonical:masterfrom
anonymouse64:feature/rm-cloud-init-unneeded-config

Conversation

@anonymouse64
Copy link
Contributor

This configuration file has the following contents:

# to update this file, run dpkg-reconfigure cloud-init
datasource_list: [ NoCloud, ConfigDrive, OpenNebula, DigitalOcean, Azure, AltCloud, OVF, MAAS, GCE, OpenStack, CloudSigma, SmartOS, Bigstep, Scaleway, AliYun, Ec2, CloudStack, Hetzner, IBMCloud, Oracle, Exoscale, RbxCloud, None ]

On Ubuntu Core, one cannot run dpkg-reconfigure for one, so the file can never
be modified in practice, and additionally we do not want to allow all possible
datasources under the sun without understanding their use cases in Ubuntu Core.

Note that already on Ubuntu Core, snapd as of 2.45.2 will write a configuration
file zzzz_snapd.cfg taking priority over this file to restrict the set of
datasources to a safe one, so we do not strictly need to delete this file, but
it will be simpler if we don't have this file.

This is the UC16 back-port of canonical/core20#78
See canonical/core18#166 for the UC18 version

…'t want

This configuration file has the following contents:

```
# to update this file, run dpkg-reconfigure cloud-init
datasource_list: [ NoCloud, ConfigDrive, OpenNebula, DigitalOcean, Azure, AltCloud, OVF, MAAS, GCE, OpenStack, CloudSigma, SmartOS, Bigstep, Scaleway, AliYun, Ec2, CloudStack, Hetzner, IBMCloud, Oracle, Exoscale, RbxCloud, None ]
```

On Ubuntu Core, one cannot run dpkg-reconfigure for one, so the file can never
be modified in practice, and additionally we do not want to allow all possible
datasources under the sun without understanding their use cases in Ubuntu Core.

Note that already on Ubuntu Core, snapd as of 2.45.2 will write a configuration
file zzzz_snapd.cfg taking priority over this file to restrict the set of
datasources to a safe one, so we do not strictly need to delete this file, but
it will be simpler if we don't have this file.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Copy link
Contributor

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, not sure if there's some policy around what priority this should have

@mvo5 mvo5 merged commit 0bcddf7 into canonical:master Aug 6, 2020
@anonymouse64 anonymouse64 deleted the feature/rm-cloud-init-unneeded-config branch August 31, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants