hooks: restore link to built initrd#134
Merged
ernestl merged 1 commit intocanonical:masterfrom Jan 17, 2024
Merged
Conversation
zyga
approved these changes
Jan 17, 2024
Contributor
zyga
left a comment
zyga
left a comment
There was a problem hiding this comment.
The change and explanation looks good. I have not test-built this myself.
bboozzoo
reviewed
Jan 17, 2024
| (cd $PREFIX | ||
| chroot . dpkg --purge --force-depends apt libapt-inst2.0 libapt-pkg5.0 lsb-release fuse | ||
| # The removal of fuse triggers a call to update-initramfs and a | ||
| # new initrd is created, remove it restore the link to the initrd |
There was a problem hiding this comment.
where is the remove step of the new initrd?
Member
Author
There was a problem hiding this comment.
In the -f of ln -sf...
Member
Author
There was a problem hiding this comment.
It actually removes regular files as well
ernestl
approved these changes
Jan 17, 2024
Member
ernestl
left a comment
ernestl
left a comment
There was a problem hiding this comment.
Looks good, one comment/question
Recent changes in xenial livebuild include the fuse package when creating the chroot - this was not until very recently. When it gets removed by hook 600-no-debian.binary, the initrd gets re-built and the symlink created by 25-create-generic-initrd.chroot is replaced by a real file. Put things back to normal by making it point back to the initrd generated by the latter.
alfonsosanchezbeato
force-pushed
the
fix-initrd-build
branch
from
8d66914 to
b23be4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes in xenial livebuild include the fuse package when creating the chroot - this was not until very recently. When it gets removed by hook 600-no-debian.binary, the initrd gets re-built and the symlink created by 25-create-generic-initrd.chroot is replaced by a real file. Put things back to normal by making it point back to the initrd generated by the latter.