fix(Application): set the plugin group on load#998
Merged
Conversation
This sets the craft-parts plugin group on application load if possible. It also ignores errors in determining the plugin group, preventing a failure to run if there is no project file or the file is invalid.
lengau
commented
Jan 29, 2026
lengau
changed the title
bepri
approved these changes
Feb 5, 2026
Member
bepri
left a comment
bepri
left a comment
There was a problem hiding this comment.
Nice, glad we were able to avoid per-base models.
mr-cal
approved these changes
Feb 6, 2026
Contributor
|
@lengau can we land this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the craft-parts plugin group on application load if possible. It also ignores errors in determining the plugin group, preventing a failure to run if there is no project file or the file is invalid.
This missing feature was discovered while implementing plugin groups in Rockcraft: canonical/rockcraft#1077 (comment)
make lint && make test?docs/reference/changelog.rst)?