feat: add prompt to emitter#315
Merged
tigarmo merged 5 commits intocanonical:mainfrom Dec 20, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 93.24% 94.56% +1.32%
==========================================
Files 7 7
Lines 1080 1197 +117
Branches 200 242 +42
==========================================
+ Hits 1007 1132 +125
+ Misses 66 59 -7
+ Partials 7 6 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dariuszd21
force-pushed
the
work/CRAFT-3739-add-prompting
branch
3 times, most recently
from
0da221a to
78963ce
Compare
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
dariuszd21
force-pushed
the
work/CRAFT-3739-add-prompting
branch
from
78963ce to
4351a07
Compare
dariuszd21
requested review from
a team,
bepri and
tigarmo
and removed request for
a team
bepri
approved these changes
Dec 20, 2024
Member
bepri
left a comment
bepri
left a comment
There was a problem hiding this comment.
Looks good! Just nitpicks, so I'm approving :)
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
Signed-off-by: Dariusz Duda <dariusz.duda@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox?Add a functionality to prompt user for an input.
Additionally with
hideset toTrueuser may be asked for a secret input.(CRAFT-3739)