Skip to content

fix(printer): stop the printer on destruct#339

Merged
tigarmo merged 1 commit intomainfrom
work/334
Apr 30, 2025
Merged

fix(printer): stop the printer on destruct#339
tigarmo merged 1 commit intomainfrom
work/334

Conversation

@lengau
Copy link
Copy Markdown
Contributor

@lengau lengau commented Apr 29, 2025

This stops the printer when garbage collecting it, even if it hasn't been manually stopped. This stops the printer before exiting the process no matter what.

Fixes #334

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

This stops the printer when garbage collecting it, even if it hasn't been
manually stopped. This stops the printer before exiting the process
no matter what.
@lengau lengau requested review from bepri and tigarmo April 29, 2025 19:35
@tigarmo tigarmo merged commit b94a6b7 into main Apr 30, 2025
10 of 11 checks passed
@tigarmo tigarmo deleted the work/334 branch April 30, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

craft-cli doesn't put the cursor back in certain error cases.

3 participants