Skip to content

[DPE-10186] add entity-type and entity-permissions to Valkey integration#291

Merged
reneradoi merged 2 commits into
mainfrom
valkey-entity-permissions
Jul 1, 2026
Merged

[DPE-10186] add entity-type and entity-permissions to Valkey integration#291
reneradoi merged 2 commits into
mainfrom
valkey-entity-permissions

Conversation

@reneradoi

Copy link
Copy Markdown
Contributor

This PR adds the fields entity-type and entity-permissions to the interface for Valkey. This is required to implement LDAP support in Valkey, as a group-mapping is supposed to be configured through Data integrator via the entity-permissions config (see DA269 for details).

An example configuration would look like this:

juju config data-integrator prefix-name="<desired_keyspace>:" entity-type="GROUP" entity-permissions="[{\"resource_name\": \"ldap_users_write\", \"resource_type\": \"acl\", \"privileges\": [\"read\", \"write\", \"pubsub\"]}, {\"resource_name\": \"ldap_users_read\", \"resource_type\": \"acl\", \"privileges\": [\"read\"]}]"

juju config valkey ldap-map="<ldap_group_name>:ldap_users_write,<another_ldap_group>:ldap_users_read"

@github-actions github-actions Bot added the Libraries: Out of sync The charm libs used are out-of-sync label Jun 30, 2026
@reneradoi reneradoi marked this pull request as ready for review June 30, 2026 16:02
@reneradoi reneradoi requested review from dragomirp and imanenami June 30, 2026 16:03

@imanenami imanenami left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reneradoi reneradoi merged commit 9952885 into main Jul 1, 2026
412 of 448 checks passed
@reneradoi reneradoi deleted the valkey-entity-permissions branch July 1, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants