patch(integration_test_charm.yaml): Remove LXD pre-download workaround#339
Merged
carlcsaposs-canonical merged 1 commit intomainfrom Feb 16, 2026
Merged
patch(integration_test_charm.yaml): Remove LXD pre-download workaround#339carlcsaposs-canonical merged 1 commit intomainfrom
carlcsaposs-canonical merged 1 commit intomainfrom
Conversation
carlcsaposs-canonical
changed the title
Co-authored-by: Neha Oudin <neha@oudin.red>
carlcsaposs-canonical
force-pushed
the
remove-lxd-predownload
branch
from
88495ac to
4e99deb
Compare
carlcsaposs-canonical
requested review from
Mehdi-Bendriss,
akram09,
delgod,
marcoppenheimer,
paulomach,
reneradoi and
taurus-forever
as code owners
reneradoi
approved these changes
Feb 16, 2026
taurus-forever
approved these changes
Feb 16, 2026
taurus-forever
left a comment
taurus-forever
left a comment
There was a problem hiding this comment.
LGTM, curios what is an impact to downloading speed (test run)?
Contributor
Author
when we added this, there was no impact to download speed (the same image needed to be downloaded) it was to workaround a timeout in juju bootstrap when the download was slow (but it did not make the overall time faster) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LXD pre-download was added in #208 as a temporary workaround with the idea that the fingerprint would be kept up-to-date
With the deprecation of integration_test_charm.yaml, it has not been kept up-to-date. Probably better to remove it to avoid issues from a 2 year old image
Outdated image was responsible for causing this issue: https://github.com/canonical/data-integrator/actions/runs/21953050611/job/63499259115?pr=226