patch: Prevent template injection#346
Merged
carlcsaposs-canonical merged 3 commits intomainfrom Mar 31, 2026
Merged
Conversation
carlcsaposs-canonical
requested review from
Mehdi-Bendriss,
akram09,
delgod,
marcoppenheimer,
paulomach,
reneradoi and
taurus-forever
as code owners
Contributor
Author
carlcsaposs-canonical
force-pushed
the
checkout-persist
branch
from
dd7adda to
2eadcd5
Compare
There is a negligible security benefit, since these inputs are trusted (we already use environment variables for untrusted input), but this can help prevent mistakes. Furthermore, it is simpler to use environment variables in all cases than to distinguish between trusted and untrusted input. (However it is still important to identify untrusted input, handle it as such, and threat model it appropriately.)
To reduce ambiguity (Prefix used to avoid accidental conflicts with other programs' environment variables)
carlcsaposs-canonical
force-pushed
the
env-variables
branch
from
483ddd0 to
1c78106
Compare
carlcsaposs-canonical
added a commit
that referenced
this pull request
Mar 31, 2026
Follow-up to #346 Fix issue when cache enabled (and VAR_NO_CACHE_ARG is not set). e.g. https://github.com/canonical/postgresql-operator/actions/runs/23791270181/job/69329452928?pr=1535#step:11:49
carlcsaposs-canonical
added a commit
that referenced
this pull request
Mar 31, 2026
Follow-up to #346 Fix issue when cache enabled (and VAR_NO_CACHE_ARG is not set). e.g. https://github.com/canonical/postgresql-operator/actions/runs/23791270181/job/69329452928?pr=1535#step:11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a negligible security benefit, since these inputs are trusted (we already use environment variables for untrusted input), but this can help prevent mistakes.
Furthermore, it is simpler to use environment variables in all cases than to distinguish between trusted and untrusted input. (However it is still important to identify untrusted input, handle it as such, and threat model it appropriately.)