Conversation
yanksyoon
commented
Dec 3, 2023
Member
Author
yanksyoon
left a comment
There was a problem hiding this comment.
Some comments to help review.
Contributor
|
Could we change the title to not include bare metal since that is more a question of what is supported by the hardware rather than what the charm supports please? |
Member
Author
|
@jdkandersson Updated, thank you! |
jdkandersson
reviewed
Dec 4, 2023
jdkandersson
reviewed
Dec 4, 2023
jdkandersson
previously approved these changes
Dec 4, 2023
cbartz
previously approved these changes
Dec 4, 2023
Collaborator
cbartz
left a comment
There was a problem hiding this comment.
LGTM, Just one small comment.
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
jdkandersson
previously approved these changes
Dec 4, 2023
cbartz
previously approved these changes
Dec 4, 2023
jdkandersson
previously approved these changes
Dec 5, 2023
cbartz
previously approved these changes
Dec 5, 2023
Contributor
|
Test coverage for ac10133 Static code analysis report |
cbartz
approved these changes
Dec 5, 2023
jdkandersson
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec: ISD097
Overview
Adds support for ARM64 deployment for bare metal arm64 machines (for non-bare metal machines, arm v8.3a or higher is required which supports nested virtualizations. See https://developer.arm.com/documentation/102142/0100/Nested-virtualization)
Link to successful CI runs: https://github.com/yanksyoon/selfhostedtest/actions/runs/7057746518/job/19211975867
Rationale
To support ARM64 workloads.
Juju Events Changes
None.
Module Changes
charm_state.pyadds a method to determine current architecture.runner.pyintroduces arm64 yq binary url.Library Changes
None.
Checklist
src-docsurgent,trivial,complex)Documentation on Charmhub should automatically be updated with the
upload-charm-docsworkflow.