Skip to content

fix: switch github-runner to be the requirer#730

Merged
cbartz merged 1 commit intomainfrom
fix/planner-requirer
Feb 18, 2026
Merged

fix: switch github-runner to be the requirer#730
cbartz merged 1 commit intomainfrom
fix/planner-requirer

Conversation

@cbartz
Copy link
Collaborator

@cbartz cbartz commented Feb 17, 2026

Applicable spec:

Overview

Switch the side of the relation with the planner charm

Counterpart PR of canonical/github-runner-operators#121

Rationale

The planner is the service provider. Even if it does not technically matter, per convention the service provider should be the provider.

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

No app version change - no need to bump

@cbartz
Copy link
Collaborator Author

cbartz commented Feb 18, 2026

Got two approvals, the test_prometheus_metrics is not passing due to infrastructure issues - unrelated to the change in this PR.. Will force merge.

@cbartz cbartz merged commit 4ab4bf4 into main Feb 18, 2026
202 of 220 checks passed
@cbartz cbartz deleted the fix/planner-requirer branch February 18, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants