Implement webhook redelivery#213
Merged
Merged
Conversation
swetha1654
commented
Jun 8, 2026
swetha1654
force-pushed
the
feat/webhook-redelivery-ISD-4482
branch
from
37ce9cf to
6c9a1ed
Compare
swetha1654
requested review from
cbartz,
javierdelapuente,
yanksyoon and
yhaliaw
as code owners
cbartz
reviewed
Jun 24, 2026
cbartz
left a comment
cbartz
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! Looks good / some mostly minor comments
cbartz
reviewed
Jun 24, 2026
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
…/canonical/github-runner-operators into feat/webhook-redelivery-ISD-4482
cbartz
approved these changes
Jun 26, 2026
cbartz
left a comment
cbartz
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, some discussion about charm validation. Forward approving - assuming my comments are addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Implement Webhook redelivery service
Why we need it
Checklist
CONTRIBUTING.mdhas been updated upon changes to the contribution/development process (e.g. changes to the way tests are run)docs/changelog.mdwith user-relevant changes(e.g., in
.github/workflows/integration_tests.yaml, ensure themoduleslist is correct)terraform fmtpasses andtflintreports no errors