Added generated OpenAPI client to GARM#232
Merged
Merged
Conversation
cbartz
reviewed
Jun 12, 2026
cbartz
reviewed
Jun 12, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Resolved in the latest commit. Three files had conflicts:
All 25 unit tests pass. |
cbartz
reviewed
Jun 16, 2026
yanksyoon
approved these changes
Jun 16, 2026
12 tasks
10 tasks
cbartz
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR targets the GARM charm.
v7.23.0) in sync with.openapi-generator/VERSION./first_runAPI, which is used to register a user on first run of GARM.charm.pyto ensure the first run API is called once. GARM is served on a single fixed port (8080);_maybe_first_runconnects via loopback usingGARM_PORTand correctly wraps IPv6 addresses in[...].mainbranch changes:_workload_configpins the workload port toGARM_PORTand disables the framework's default metrics scrape job (metrics are declared inpaas-config.yaml).Why we need it
Standardize the API calling process in the GARM charm.
Register the user of GARM in the GARM charm.
Checklist
CONTRIBUTING.mdhas been updated upon changes to the contribution/development process (e.g. changes to the way tests are run)docs/changelog.mdwith user-relevant changes(e.g., in
.github/workflows/integration_tests.yaml, ensure themoduleslist is correct)terraform fmtpasses andtflintreports no errors