Conversation
# Conflicts: # .github/workflows/tests.yaml # .github/workflows/webhook_gateway_tests.yaml
This reverts commit 3050f7e
cbartz
commented
Sep 30, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the webhook-gateway charm to the repository, introducing a complete charm implementation for deploying a webhook gateway application using the 12 Factor framework. The implementation includes the charm code, test configuration, and library dependencies.
Key Changes:
- Created a complete charm structure with Go application integration
- Added comprehensive integration test setup with RabbitMQ
- Migrated from hardcoded strings to environment variable constants for better maintainability
Reviewed Changes
Copilot reviewed 31 out of 33 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| webhook-gateway/main.go | Refactored to use environment variable constants instead of hardcoded strings |
| webhook-gateway/webhook_test.go | Updated test functions to use new environment variable constants |
| webhook-gateway/charm/ | Complete charm implementation with source code, configuration, libraries, and tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cbartz
requested review from
florentianayuwono,
javierdelapuente,
weiiwang01,
yanksyoon and
yhaliaw
as code owners
weiiwang01
approved these changes
Oct 1, 2025
javierdelapuente
approved these changes
Oct 1, 2025
Collaborator
javierdelapuente
left a comment
javierdelapuente
left a comment
There was a problem hiding this comment.
Looks good, a few minor comments
erinecon
reviewed
Oct 1, 2025
Co-authored-by: Erin Conley <erin.conley@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add the charm using 12 F.
Add a simple charm integration test that integrates with rabbitmq.
Rationale
In order to deploy the webhook gateway application, we build a charm.
Checklist
urgent,trivial,senior-review-required,documentation).