Conversation
cbartz
requested review from
javierdelapuente,
weiiwang01,
yanksyoon and
yhaliaw
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds basic access logging functionality to the webhook server to help operators understand deployment activity. The logging follows Apache Common Log Format, providing structured request information including IP address, timestamp, HTTP method, status code, and user agent.
- Replaces direct
http.Errorcalls with a newrespondWithErrorfunction that includes logging - Adds access logging for both successful and error responses
- Implements Apache-style log format with timestamp, request details, and response information
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
javierdelapuente
approved these changes
Oct 6, 2025
Collaborator
javierdelapuente
left a comment
javierdelapuente
left a comment
There was a problem hiding this comment.
Looks good. Just if the file increase I would consider using a middleware to wrap the handler.
weiiwang01
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add basic access logs
e.g.
Rationale
To help the operator understanding the deployment
Checklist
urgent,trivial,senior-review-required,documentation).