add logic to set allowed-hosts if haproxy has sent a proxied-endpoint by Thanhphan1147 · Pull Request #475 · canonical/haproxy-operator

Thanhphan1147 · 2026-04-20T15:21:27Z

Add missing logic to the haproxy-route-policy charm to set the allowed-hosts snap config with the value of the proxied-endpoint sent over by haproxy

Checklist

The charm style guide was applied
The contributing guide was applied
The changes are compliant with ISD054 - Managing Charm Complexity
The documentation is updated
A change artifact was added for user-relevant changes in docs/release-notes/artifacts. If this PR does not require a change artifact, the PR has been tagged with no-release-note.
The PR is tagged with appropriate label (urgent, trivial, complex)
The changelog is updated with user-relevant changes in the format of keep a changelog v1.1.0

* update how-to landing page * Update docs/how-to/index.md Co-authored-by: Erin Conley <erin.conley@canonical.com> * add summary for each section * Update docs/how-to/index.md Co-authored-by: Erin Conley <erin.conley@canonical.com> * Update docs/how-to/index.md Co-authored-by: Erin Conley <erin.conley@canonical.com> * Update docs/how-to/index.md Co-authored-by: Erin Conley <erin.conley@canonical.com> --------- Co-authored-by: Erin Conley <erin.conley@canonical.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…ice' into automatically_configure_allowed_hosts_for_haproxy_route_policy

…re_allowed_hosts_for_haproxy_route_policy

…proxy_route_policy

github-actions · 2026-04-22T12:12:48Z

Test results for commit `d97a984`

Test coverage for d97a984

Name                                       Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------------------
lib/charms/haproxy/v0/ddos_protection.py     154     51     34      8    64%   157-174, 183-187, 288, 316-318, 323, 326-330, 342-344, 381, 387, 393, 396, 424, 495-498, 510-529
src/charm.py                                  21      0      0      0   100%
src/state.py                                  43      0      0      0   100%
--------------------------------------------------------------------------------------
TOTAL                                        218     51     34      8    73%

Static code analysis report

Run started:2026-04-22 12:09:15.907668+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 333
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-04-22T12:12:49Z

Test results for commit `d97a984`

Test coverage for d97a984

Name                                         Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------------------------
lib/charms/haproxy/v0/ddos_protection.py       154     42     34      3    72%   157-174, 183-187, 265, 284, 415-418, 422-424, 459-478, 514-529
lib/charms/haproxy/v0/spoe_auth.py             158     55     32      2    59%   203, 304-306, 315, 354-381, 392-402, 441-442, 459-472, 484-501, 522-525, 529-531
lib/charms/haproxy/v1/haproxy_route_tcp.py     385    153     78      8    56%   209, 212, 281, 290-293, 297-300, 318-321, 336, 342-347, 447, 452, 829-832, 836, 863-874, 897-900, 904-906, 926-928, 1042-1083, 1087-1093, 1097, 1166-1195, 1266-1305, 1335-1337, 1362-1364, 1386-1390, 1409-1411, 1429-1431, 1438-1444, 1452-1454, 1462-1463, 1474-1481, 1494-1505, 1513-1534, 1546-1547, 1558-1559, 1570-1573, 1584-1585, 1614-1623, 1639-1642, 1658-1669, 1685-1688, 1706-1717, 1728-1729, 1737-1738, 1746-1747, 1758-1761
lib/charms/haproxy/v2/haproxy_route.py         385     53     98     26    82%   181, 257, 266-269, 294-297, 318-323, 673-674, 860->exit, 867, 893-904, 927-930, 934-936, 955-957, 1129-1135, 1139, 1336->1338, 1340->1342, 1342->1344, 1344->1346, 1346->1348, 1348->1351, 1386, 1394, 1399, 1402, 1427, 1455, 1459, 1463, 1486, 1506, 1515-1516, 1518->exit, 1554-1556, 1576, 1590, 1595-1597
src/charm.py                                   293     71     84     13    71%   102, 228, 236-252, 257, 262, 280, 291, 297-298, 332-352, 371, 471, 478-486, 514-527, 540-545, 554, 567-568, 575, 585, 595, 601-607, 623, 674-677, 683->682, 696-699
src/haproxy.py                                 125     31      6      2    75%   108-114, 134-156, 266-267, 270, 278-284, 312, 342-353, 365-367, 377-378
src/http_interface.py                           73     25      4      0    62%   74, 83, 92, 106-108, 126, 138, 150, 162, 170-175, 187, 194, 202, 217-227
src/state/charm_state.py                        78     15     14      4    79%   94-96, 101-102, 105, 150-155, 164, 216-218, 230-231
src/state/ddos_protection.py                    39      0      2      0   100%
src/state/exception.py                           1      0      0      0   100%
src/state/ha.py                                 30      1      2      1    94%   50
src/state/haproxy_route.py                     284     46     76      8    82%   161, 190-199, 256, 281, 332-360, 369, 378, 387, 396, 408, 446-472, 528, 568, 584-585, 602, 817-830
src/state/haproxy_route_tcp.py                 120     17     42      1    80%   92-94, 109->112, 147-160
src/state/ingress.py                            38      0      4      0   100%
src/state/ingress_per_unit.py                   32      0      4      0   100%
src/state/spoe_auth.py                          26      2      2      0    93%   63-64
src/state/tls.py                                39      7     12      4    78%   74, 77-78, 127-135, 141-142
src/state/validation.py                         46     23      8      1    44%   66-67, 71-98
src/tls_relation.py                             62      3     14      3    92%   87->86, 119-129, 141->143
----------------------------------------------------------------------------------------
TOTAL                                         2368    544    516     76    74%

Static code analysis report

Working... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00
Run started:2026-04-22 12:09:35.298719+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 10625
  Total lines skipped (#nosec): 13
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 10

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-04-22T12:12:49Z

Test results for commit `d97a984`

Test coverage for d97a984

Name                      Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------
src/charm.py                 73     20     10      2    69%   92-93, 102-112, 140-152, 160-180
src/policy.py                66     37      2      0    43%   30-32, 37-38, 43-53, 58-59, 64-65, 78-92, 115-117, 140-141, 159-176, 187-197, 208-211
src/state/database.py        32      2      6      2    89%   76, 79
src/state/policy.py          62      2     10      2    94%   94, 106
src/state/validation.py      44     18      0      0    59%   57-59, 61-63, 74-87
---------------------------------------------------------------------
TOTAL                       277     79     28      6    70%

Static code analysis report

Run started:2026-04-22 12:09:21.124101+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1133
  Total lines skipped (#nosec): 10
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-04-22T12:12:50Z

Test results for commit `d97a984`

Test coverage for d97a984

Name                                        Stmts   Miss  Cover
---------------------------------------------------------------
haproxy_route_policy/__init__.py                0      0   100%
haproxy_route_policy/settings.py               30      1    97%
haproxy_route_policy/test_settings.py           4      0   100%
haproxy_route_policy/urls.py                    7      0   100%
manage.py                                      11      2    82%
policy/__init__.py                              0      0   100%
policy/admin.py                                22      5    77%
policy/apps.py                                  3      0   100%
policy/db_models.py                            50      2    96%
policy/management/__init__.py                   0      0   100%
policy/management/commands/__init__.py          0      0   100%
policy/middleware.py                           16      4    75%
policy/migrations/0001_initial.py               7      0   100%
policy/migrations/0002_rule.py                  5      0   100%
policy/migrations/0003_alter_rule_kind.py       4      0   100%
policy/migrations/__init__.py                   0      0   100%
policy/rule_engine.py                          42      6    86%
policy/serializers.py                          30      4    87%
policy/tests/__init__.py                        0      0   100%
policy/tests/test_auth.py                      36     20    44%
policy/tests/test_models.py                    85      0   100%
policy/tests/test_rule_engine.py              117      0   100%
policy/tests/test_views.py                    201      0   100%
policy/urls.py                                  3      0   100%
policy/views.py                                95     16    83%
---------------------------------------------------------------
TOTAL                                         768     60    92%

Static code analysis report

Run started:2026-04-22 12:09:15.318556+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1680
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-04-22T12:12:50Z

Test results for commit `d97a984`

Test coverage for d97a984

Name                               Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------------
src/charm.py                          45      9      2      0    77%   65-91, 96-98
src/haproxy_spoe_auth_service.py      44     16      2      0    61%   56-64, 76-82, 93-117
src/state.py                          55     15      6      1    67%   64-66, 79, 125-146
------------------------------------------------------------------------------
TOTAL                                144     40     10      1    68%

Static code analysis report

Run started:2026-04-22 12:09:20.184690

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 409
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

- .github/skills/pr-best-practices/SKILL.md: skill that analyzes merged LLM-authored PRs, compares first vs final commit, and synthesizes do/don't rules with concrete code examples into best-practices.instructions.md - .github/skills/pr-best-practices/evals/evals.json: 3 eval cases covering substantive PR, validation-fix PR, and trivial (non-significant) PR - .github/instructions/best-practices.instructions.md: initial rules extracted from PR #475 (relation contracts, reconcile flow, testing) and PR #500 (validation error handling) with before/after code examples - .gitignore: ignore *-workspace/ directories (skill eval scratch data) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Thanhphan1147 and others added 30 commits March 17, 2026 15:08

Implement request API

7b7a688

update model validation before save and add unit tests

4540250

use environment variables for secret key

2111aa1

ruff format

0f1bbfd

add secret key for testing

2c7bd78

remove port attribute from test

cbd051e

add requirements.txt for testing

eac8f31

reintroduce port field

45f1886

Add change artifact

4b5b49a

run lint with uv

b143b06

add unit testing

02bb32f

remove custom test

99f56fd

update migration

e825d3a

Wrap creation under transaction.atomic

cceb382

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

e841faa

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

remove unused code

597aa03

minor fixes to settings

5c9441d

use django serializer

9e981b6

update gitignore

f4508e7

Potential fix for pull request finding

6a49660

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

update view to use django rest

ef41d0f

remove python-version

447e25f

update gitignore

2601119

add missing license headers

b7f3827

Add rules engine

3d47843

update migration

4a066ea

update view

01e6da2

fix lint

fc6ecc6

remove extra tests

570def0

Merge remote-tracking branch 'origin/expose_haproxy_route_policy_serv…

0dda1b7

…ice' into automatically_configure_allowed_hosts_for_haproxy_route_policy

github-actions Bot added Libraries: Out of sync Libraries: OK and removed Libraries: Out of sync Libraries: OK labels Apr 21, 2026

Base automatically changed from expose_haproxy_route_policy_service to main April 21, 2026 18:01

Thanhphan1147 added 2 commits April 21, 2026 20:23

add change artifact

647f20f

Merge remote-tracking branch 'origin/main' into automatically_configu…

a39e544

…re_allowed_hosts_for_haproxy_route_policy

Thanhphan1147 enabled auto-merge (squash) April 21, 2026 18:24

github-actions Bot added Libraries: OK Libraries: Out of sync and removed Libraries: OK labels Apr 21, 2026

update lib schema to not send a HttpUrl but send the hostname directly

3833188

github-actions Bot added Libraries: OK Libraries: Out of sync and removed Libraries: Out of sync Libraries: OK labels Apr 22, 2026

Merge branch 'main' into automatically_configure_allowed_hosts_for_ha…

d97a984

…proxy_route_policy

github-actions Bot added Libraries: OK and removed Libraries: Out of sync labels Apr 22, 2026

Thanhphan1147 merged commit d2bc6d8 into main Apr 22, 2026
103 of 105 checks passed

Thanhphan1147 deleted the automatically_configure_allowed_hosts_for_haproxy_route_policy branch April 22, 2026 15:49

Thanhphan1147 mentioned this pull request May 4, 2026

Add pr-best-practices skill #504

Open

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add logic to set allowed-hosts if haproxy has sent a proxied-endpoint#475

add logic to set allowed-hosts if haproxy has sent a proxied-endpoint#475
Thanhphan1147 merged 230 commits intomainfrom
automatically_configure_allowed_hosts_for_haproxy_route_policy

Thanhphan1147 commented Apr 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Thanhphan1147 commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions Bot commented Apr 22, 2026

Test results for commit d97a984

Uh oh!

github-actions Bot commented Apr 22, 2026

Test results for commit d97a984

Uh oh!

github-actions Bot commented Apr 22, 2026

Test results for commit d97a984

Uh oh!

github-actions Bot commented Apr 22, 2026

Test results for commit d97a984

Uh oh!

github-actions Bot commented Apr 22, 2026

Test results for commit d97a984

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Thanhphan1147 commented Apr 20, 2026 •

edited

Loading

Test results for commit `d97a984`

Test results for commit `d97a984`

Test results for commit `d97a984`

Test results for commit `d97a984`

Test results for commit `d97a984`