Skip to content

Update ftp tutorial to use port range#569

Merged
Thanhphan1147 merged 7 commits into
mainfrom
update-ftp-tutorial-port-range
Jun 26, 2026
Merged

Update ftp tutorial to use port range#569
Thanhphan1147 merged 7 commits into
mainfrom
update-ftp-tutorial-port-range

Conversation

@Thanhphan1147

@Thanhphan1147 Thanhphan1147 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

This PR will be in draft until ingress-configurator is updated. Updates the FTP guide to use the new port-range feature

What this PR does

Why we need it

Checklist

  • I followed the contributing guide
  • I added or updated the documentation (if applicable)
  • I updated docs/changelog.md with user-relevant changes
  • I added a change artifact for user-relevant changes in docs/release-notes/artifacts. If no change artifact is necessary, I tagged the PR with the label no-release-note.
  • I used AI to assist with preparing this PR
  • I added or updated tests as needed (unit and integration)
  • If integration test modules are used: I updated the workflow configuration
    (e.g., in .github/workflows/integration_tests.yaml, ensure the modules list is correct)
  • If this PR involves a Grafana dashboard: I added a screenshot of the dashboard
  • If this PR involves Terraform: terraform fmt passes and tflint reports no errors

The FTP passive mode data channel requires a range of ports, not a
single port. Update the guide to:

- Configure vsftpd with a proper passive port range (10100–10200)
- Replace the single tcp-backend-port/tcp-frontend-port config for
  the data channel with tcp-port-mapping=10100-10200:10100-10200
- Add an explanation that the port-mapping attribute is designed for
  protocols like FTP that operate over a range of ports
- Fix the machine number in the jq expression (.machines."5" -> .machines."1")
@Thanhphan1147 Thanhphan1147 added documentation Improvements or additions to documentation no-release-note This PR does not require a change artifact labels Jun 22, 2026
- Remove spurious double blank line before section heading (MD022)
- Add docs/release-notes/artifacts/pr0569.yaml for CI compliance
@Thanhphan1147 Thanhphan1147 marked this pull request as ready for review June 24, 2026 14:16
@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner June 24, 2026 14:16
@Thanhphan1147 Thanhphan1147 requested a review from erinecon June 24, 2026 14:16
@Thanhphan1147 Thanhphan1147 enabled auto-merge (squash) June 24, 2026 14:17

@erinecon erinecon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

@Thanhphan1147 Thanhphan1147 merged commit 99e8855 into main Jun 26, 2026
130 of 133 checks passed
@Thanhphan1147 Thanhphan1147 deleted the update-ftp-tutorial-port-range branch June 26, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Libraries: Out of sync no-release-note This PR does not require a change artifact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants