Merged
Conversation
888e17d to
266659c
Compare
04c12b4 to
8526cea
Compare
gregory-schiano
previously approved these changes
Sep 26, 2024
gregory-schiano
previously approved these changes
Sep 26, 2024
cbartz
reviewed
Sep 27, 2024
Contributor
cbartz
left a comment
There was a problem hiding this comment.
Looks good, have a few questions and nitpicks. Any plans to add tests?
Contributor
|
Test coverage for 618a484 Static code analysis report |
cbartz
approved these changes
Sep 27, 2024
Contributor
cbartz
left a comment
There was a problem hiding this comment.
LGTM, except the doc string I mentioned in a comment
javierdelapuente
approved these changes
Sep 27, 2024
Collaborator
Author
|
Thanks for the reviews! I'll merge the PR now and I'll update the docstring in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec: ISD163 (internal)
Overview
Add certificates relation and certificate management logic
Checklist
src-docsurgent,trivial,complex)