Skip to content

Add certificates integration#6

Merged
Thanhphan1147 merged 72 commits intomainfrom
certificates_integration
Sep 27, 2024
Merged

Add certificates integration#6
Thanhphan1147 merged 72 commits intomainfrom
certificates_integration

Conversation

@Thanhphan1147
Copy link
Collaborator

@Thanhphan1147 Thanhphan1147 commented Aug 6, 2024

Applicable spec: ISD163 (internal)

Overview

Add certificates relation and certificate management logic

Checklist

@Thanhphan1147 Thanhphan1147 force-pushed the certificates_integration branch from 888e17d to 266659c Compare August 12, 2024 11:33
@Thanhphan1147 Thanhphan1147 force-pushed the certificates_integration branch from 04c12b4 to 8526cea Compare September 17, 2024 21:44
@Thanhphan1147 Thanhphan1147 marked this pull request as ready for review September 23, 2024 11:29
@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner September 23, 2024 11:29
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have a few questions and nitpicks. Any plans to add tests?

@github-actions
Copy link
Contributor

Test coverage for 618a484

Name                      Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------
src/charm.py                 83     53     24      0    39%   43-64, 71-72, 77-78, 83, 92-94, 103-106, 117-124, 131-132, 140-153, 157-159, 163-178
src/haproxy.py               47     14      4      1    67%   63, 71-72, 88-91, 101-103, 115-119
src/state/config.py          40     22     20      0    47%   50-70, 85-93, 105-106
src/state/tls.py             38     18     12      0    52%   53-68, 84-96
src/state/validation.py      31     17     10      0    39%   59-75
src/tls_relation.py         117     82     20      0    26%   63-76, 89-92, 100-101, 109-116, 125-143, 157-164, 177-180, 190-200, 217-239, 250, 254-255, 263-271, 279-281, 292-296, 309-313
---------------------------------------------------------------------
TOTAL                       356    206     90      1    41%

Static code analysis report

Run started:2024-09-27 11:46:20.170865

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 799
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 3

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the doc string I mentioned in a comment

@Thanhphan1147
Copy link
Collaborator Author

Thanks for the reviews! I'll merge the PR now and I'll update the docstring in a follow-up PR.

@Thanhphan1147 Thanhphan1147 merged commit 79ccad4 into main Sep 27, 2024
@Thanhphan1147 Thanhphan1147 deleted the certificates_integration branch September 27, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants