Add logic for importing devices from C3 #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omar-selo
requested changes
May 3, 2024
omar-selo
left a comment
omar-selo
left a comment
There was a problem hiding this comment.
Some small comments but a couple a bit more involved. Would it not be better to extend the existing certificates endpoint on C3 to include devices. And do we want device instances or not
omar-selo
approved these changes
May 6, 2024
omar-selo
left a comment
omar-selo
left a comment
There was a problem hiding this comment.
LGTM! thanks for addressing my comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes C3-649. It depends on https://github.com/canonical/hexr/pull/307 and uses the endpoint defined there
Here we introduce the Device model and the M2M relationship between it and the Report model to reflect the structure that we have in C3.
The importer logic adds a new device only if another device with the same vendor, name, subsystem, bus, version, and category doesn't exist. It was done this way to avoid populating duplicates but keeping as much information as we need to identify a device
There also were added two tests: