fix: use shlex.join for safe command construction in snap-preseed plugin#325
Draft
fix: use shlex.join for safe command construction in snap-preseed plugin#325
Conversation
4 tasks
Agent-Logs-Url: https://github.com/canonical/imagecraft/sessions/2390df9f-e724-4191-8188-e2ec39b78dd0 Co-authored-by: lengau <4305943+lengau@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on snap prepare-image plugins PR
fix: use shlex.join for safe command construction in snap-preseed plugin
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command construction in
get_build_commandsmixed manual double-quote wrapping with string concatenation, combining the model assert path and install dir into a single list element — fragile for paths with spaces or shell-special characters.Changes
snap_preseed_plugin.py: Split model assert and install dir into separatecmdlist items; replace" ".join(cmd)withshlex.join(cmd)for safe shell quotingtest_snap_preseed_plugin.py: Update expected strings to matchshlex.joinoutput (empty model assert →'';model.assert→ unquoted)Before:
After: