Skip to content

feat(Lifecycle)!: use craft-application's new plugin groups#326

Open
lengau wants to merge 2 commits intomainfrom
work/update-plugin-groups
Open

feat(Lifecycle)!: use craft-application's new plugin groups#326
lengau wants to merge 2 commits intomainfrom
work/update-plugin-groups

Conversation

@lengau
Copy link
Copy Markdown
Collaborator

@lengau lengau commented Apr 21, 2026

Breaking change: We're extending the MINIMAL plugin group rather than the DEFAULT plugin group so that we can pick upstream plugins as needed, ensuring they work with imagecraft.

Fixes #314
IMAGECRAFT-121


Breaking change: We're extending the MINIMAL plugin group rather than
the DEFAULT plugin group so that we can pick upstream plugins as needed,
ensuring they work with imagecraft.
@lengau lengau changed the title feat!(Lifecycle): use craft-application's new plugin groups feat(Lifecycle)!: use craft-application's new plugin groups Apr 21, 2026
@lengau lengau marked this pull request as ready for review April 21, 2026 20:55
@lengau lengau requested review from a team and Copilot April 21, 2026 20:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Imagecraft’s lifecycle/plugin integration to use craft-application’s new “plugin groups” mechanism, switching the baseline group to MINIMAL so upstream plugins can be selected more explicitly for Imagecraft compatibility.

Changes:

  • Add ImagecraftLifecycleService.get_plugin_group() to return PluginGroup.MINIMAL plus Imagecraft-specific plugins.
  • Remove Imagecraft._get_app_plugins() override from the main Application class (plugin selection now handled via lifecycle plugin groups).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
imagecraft/services/lifecycle.py Introduces get_plugin_group() to merge MINIMAL group plugins with Imagecraft’s custom plugins.
imagecraft/application.py Removes the legacy app plugin hook that’s superseded by the new plugin-group mechanism.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread imagecraft/services/lifecycle.py
Comment thread imagecraft/services/lifecycle.py
Comment thread imagecraft/services/lifecycle.py
@tigarmo tigarmo requested review from a team April 24, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable untested plugins

4 participants