Conversation
upils
changed the title
upils
force-pushed
the
work/CRAFT-3961-Prototype-partitions-definition-and-usage-in-Imagecraft
branch
2 times, most recently
from
b883f82 to
f7c5b5f
Compare
upils
commented
Jan 21, 2025
upils
commented
Jan 21, 2025
upils
commented
Jan 21, 2025
upils
force-pushed
the
work/CRAFT-3961-Prototype-partitions-definition-and-usage-in-Imagecraft
branch
2 times, most recently
from
dba6801 to
0301b5d
Compare
tigarmo
reviewed
Jan 22, 2025
upils
force-pushed
the
work/CRAFT-3961-Prototype-partitions-definition-and-usage-in-Imagecraft
branch
2 times, most recently
from
6da1003 to
81f210b
Compare
cmatsuoka
reviewed
Jan 24, 2025
upils
force-pushed
the
work/CRAFT-3961-Prototype-partitions-definition-and-usage-in-Imagecraft
branch
2 times, most recently
from
5f7f50d to
7df13a5
Compare
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Instead of copying it, use VALID_PARTITION_REGEX and make it more strict (and explain why). Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
upils
force-pushed
the
work/CRAFT-3961-Prototype-partitions-definition-and-usage-in-Imagecraft
branch
from
eecb48e to
224cb91
Compare
upils
deleted the
work/CRAFT-3961-Prototype-partitions-definition-and-usage-in-Imagecraft
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the subset of the Volumes specification defined in https://docs.google.com/document/d/12LxcUIUEoXvzK619CvK9eHU_8n_rEKnLPEC4clsriXA/edit?pli=1&tab=t.0
CRAFT-3972