Merged
Conversation
…ersed` Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
There was a problem hiding this comment.
Pull request overview
Prepares LXD for an upcoming golangci-lint update by adjusting slice initialization patterns to satisfy newer prealloc linter behavior, without changing runtime logic.
Changes:
- Preallocate
inheritKeysin NICvalidateConfig()paths so subsequentappend()operations avoid allocations. - Preallocate
DevicesSortableinDevices.Sorted()andDevices.Reversed()based on the number of devices.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lxd/device/nic_sriov.go |
Preallocates inheritKeys to avoid allocations when building bannedKeys. |
lxd/device/nic_macvlan.go |
Same preallocation pattern as SR-IOV for inheritKeys/bannedKeys. |
lxd/device/nic_bridged.go |
Preallocates inheritKeys to avoid allocations when extending into bannedKeys. |
lxd/device/config/devices.go |
Preallocates DevicesSortable slices in sorting helpers to satisfy prealloc. |
Member
Author
|
@tomponline I've put up a reminder to verify that Dependabot will pick up the new [ |
tomponline
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation of Dependabot pulling a new
golangci-lint(after the 7 day cooldown) which will bring newerpreallocversion.