fix: modernize type annotations and make zip strictness explicit#100
Merged
alexsander-souza merged 1 commit intocanonical:resolute_supportfrom Apr 1, 2026
Conversation
Contributor
alexsander-souza
commented
Apr 1, 2026
alexsander-souza
commented
- files.py: replace Optional[str]/Union[str, None] with str | None and drop the now-unused Optional and Union imports
- config_forms.py: pass strict=False in DictCharField.compress() where the length mismatch is intentional (skip_check adds SKIP_CHECK_NAME to self.names but not to the data list); pass strict=True in DictCharWidget.init() where names and widgets must always align
…icit - files.py: replace Optional[str]/Union[str, None] with str | None and drop the now-unused Optional and Union imports - config_forms.py: pass strict=False in DictCharField.compress() where the length mismatch is intentional (skip_check adds SKIP_CHECK_NAME to self.names but not to the data list); pass strict=True in DictCharWidget.__init__() where names and widgets must always align
alexsander-souza
changed the title
r00ta
approved these changes
Apr 1, 2026
alexsander-souza
merged commit 33d6ce9
into
canonical:resolute_support
1 of 2 checks passed
alexsander-souza
added a commit
that referenced
this pull request
Apr 8, 2026
- files.py: replace Optional[str]/Union[str, None] with str | None and drop the now-unused Optional and Union imports - config_forms.py: pass strict=False in DictCharField.compress() where the length mismatch is intentional (skip_check adds SKIP_CHECK_NAME to self.names but not to the data list); pass strict=True in DictCharWidget.__init__() where names and widgets must always align
alexsander-souza
added a commit
that referenced
this pull request
Apr 8, 2026
- files.py: replace Optional[str]/Union[str, None] with str | None and drop the now-unused Optional and Union imports - config_forms.py: pass strict=False in DictCharField.compress() where the length mismatch is intentional (skip_check adds SKIP_CHECK_NAME to self.names but not to the data list); pass strict=True in DictCharWidget.__init__() where names and widgets must always align
alexsander-souza
added a commit
that referenced
this pull request
Apr 9, 2026
- files.py: replace Optional[str]/Union[str, None] with str | None and drop the now-unused Optional and Union imports - config_forms.py: pass strict=False in DictCharField.compress() where the length mismatch is intentional (skip_check adds SKIP_CHECK_NAME to self.names but not to the data list); pass strict=True in DictCharWidget.__init__() where names and widgets must always align
alexsander-souza
added a commit
that referenced
this pull request
Apr 17, 2026
- files.py: replace Optional[str]/Union[str, None] with str | None and drop the now-unused Optional and Union imports - config_forms.py: pass strict=False in DictCharField.compress() where the length mismatch is intentional (skip_check adds SKIP_CHECK_NAME to self.names but not to the data list); pass strict=True in DictCharWidget.__init__() where names and widgets must always align
alexsander-souza
added a commit
that referenced
this pull request
Apr 17, 2026
- files.py: replace Optional[str]/Union[str, None] with str | None and drop the now-unused Optional and Union imports - config_forms.py: pass strict=False in DictCharField.compress() where the length mismatch is intentional (skip_check adds SKIP_CHECK_NAME to self.names but not to the data list); pass strict=True in DictCharWidget.__init__() where names and widgets must always align
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.