Skip to content

build: fix binary source paths in debian install files#159

Merged
alexsander-souza merged 1 commit intocanonical:resolute_supportfrom
alexsander-souza:deb_packaging
Apr 15, 2026
Merged

build: fix binary source paths in debian install files#159
alexsander-souza merged 1 commit intocanonical:resolute_supportfrom
alexsander-souza:deb_packaging

Conversation

@alexsander-souza
Copy link
Copy Markdown
Contributor

Corrects the source paths for maas-agent, maas-netmon, and OpenFGA binaries in their respective .install files from bin/ to usr/sbin/, matching the actual build output locations.

@alemar99
Copy link
Copy Markdown
Contributor

I'm a bit confused. Looking at https://www.debian.org/doc/manuals/maint-guide/dother.en.html#install the first part is where the binary is located and the second part where it should be installed, so they look okay to me.

The built binaries are not inside bin/?

The changes that you are proposing don't do basically anything since the binaries are already in the right path?

@alexsander-souza
Copy link
Copy Markdown
Contributor Author

@alemar99 we do need the changes, but they can be simplified as the source and destination relative paths are the same (just did this).

We must enumerate the files even if they are already installed in their final destinations because we are building multiple binary packages from one source, so debhelper needs this to know which file to put in each package.

Copy link
Copy Markdown
Contributor

@alemar99 alemar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation

@alexsander-souza alexsander-souza merged commit d46c3af into canonical:resolute_support Apr 15, 2026
7 checks passed
@alexsander-souza alexsander-souza deleted the deb_packaging branch April 15, 2026 16:26
alexsander-souza added a commit that referenced this pull request Apr 17, 2026
Corrects the source paths for maas-agent, maas-netmon, and OpenFGA
binaries in their respective .install files from bin/ to usr/sbin/,
matching the actual build output locations.
alexsander-souza added a commit that referenced this pull request Apr 17, 2026
Corrects the source paths for maas-agent, maas-netmon, and OpenFGA
binaries in their respective .install files from bin/ to usr/sbin/,
matching the actual build output locations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants