refactor(twisted): replace returnValue() with return in inlineCallbacks#80
Merged
alexsander-souza merged 1 commit intocanonical:resolute_supportfrom Mar 31, 2026
Conversation
Remove all returnValue(x) calls inside @inlineCallbacks functions. returnValue was a Python 2 generator workaround and produces DeprecationWarnings under Python 3. Also removes dead bare `return` statements that followed returnValue() calls (a static-analyser workaround no longer needed with plain return), and fixes a broken mock in test_pods.py where returnValue() was used as a mock return value instead of succeed(), causing the test to exit early before its assertions ran. Affected modules: provisioningserver/monkey.py, rpc/common.py, rpc/utils.py, rpc/power.py, rpc/clusterservice.py, rpc/testing/__init__.py, utils/twisted.py, utils/service_monitor.py, rackdservices/networks_monitoring_service.py, rackdservices/tftp.py, rackdservices/version_update_check.py, drivers/power/__init__.py, maasserver/rpc/regionservice.py, maasserver/models/node.py, maasserver/websockets/protocol.py, maasserver/triggers/testing.py, maasserver/regiondservices/networks_monitoring.py, maasserver/rpc/testing/fixtures.py, maastesting/runtest.py
r00ta
approved these changes
Mar 31, 2026
alexsander-souza
merged commit 2c04817
into
canonical:resolute_support
1 of 2 checks passed
alexsander-souza
added a commit
that referenced
this pull request
Apr 8, 2026
…ks (#80) Remove all returnValue(x) calls inside @inlineCallbacks functions. returnValue was a Python 2 generator workaround and produces DeprecationWarnings under Python 3. Also removes dead bare `return` statements that followed returnValue() calls (a static-analyser workaround no longer needed with plain return), and fixes a broken mock in test_pods.py where returnValue() was used as a mock return value instead of succeed(), causing the test to exit early before its assertions ran.
alexsander-souza
added a commit
that referenced
this pull request
Apr 8, 2026
…ks (#80) Remove all returnValue(x) calls inside @inlineCallbacks functions. returnValue was a Python 2 generator workaround and produces DeprecationWarnings under Python 3. Also removes dead bare `return` statements that followed returnValue() calls (a static-analyser workaround no longer needed with plain return), and fixes a broken mock in test_pods.py where returnValue() was used as a mock return value instead of succeed(), causing the test to exit early before its assertions ran.
alexsander-souza
added a commit
that referenced
this pull request
Apr 9, 2026
…ks (#80) Remove all returnValue(x) calls inside @inlineCallbacks functions. returnValue was a Python 2 generator workaround and produces DeprecationWarnings under Python 3. Also removes dead bare `return` statements that followed returnValue() calls (a static-analyser workaround no longer needed with plain return), and fixes a broken mock in test_pods.py where returnValue() was used as a mock return value instead of succeed(), causing the test to exit early before its assertions ran.
alexsander-souza
added a commit
that referenced
this pull request
Apr 17, 2026
…ks (#80) Remove all returnValue(x) calls inside @inlineCallbacks functions. returnValue was a Python 2 generator workaround and produces DeprecationWarnings under Python 3. Also removes dead bare `return` statements that followed returnValue() calls (a static-analyser workaround no longer needed with plain return), and fixes a broken mock in test_pods.py where returnValue() was used as a mock return value instead of succeed(), causing the test to exit early before its assertions ran.
alexsander-souza
added a commit
that referenced
this pull request
Apr 17, 2026
…ks (#80) Remove all returnValue(x) calls inside @inlineCallbacks functions. returnValue was a Python 2 generator workaround and produces DeprecationWarnings under Python 3. Also removes dead bare `return` statements that followed returnValue() calls (a static-analyser workaround no longer needed with plain return), and fixes a broken mock in test_pods.py where returnValue() was used as a mock return value instead of succeed(), causing the test to exit early before its assertions ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all returnValue(x) calls inside @inlineCallbacks functions. returnValue was a Python 2 generator workaround and produces DeprecationWarnings under Python 3.
Also removes dead bare
returnstatements that followed returnValue() calls (a static-analyser workaround no longer needed with plain return), and fixes a broken mock in test_pods.py where returnValue() was used as a mock return value instead of succeed(), causing the test to exit early before its assertions ran.