fix(compat): fix deprecated stdlib and third-party API usages for Python 3.14#81
Merged
alexsander-souza merged 2 commits intocanonical:resolute_supportfrom Apr 2, 2026
Conversation
…hon 3.14 Address runtime warnings and errors surfaced by the Python 3.14 and dependency upgrades, separate from the Twisted deprecations (PR-05) and test-framework fixes (PR-10). - asyncio.iscoroutinefunction removed in 3.12 -> inspect.iscoroutinefunction - re.split positional maxsplit -> keyword argument maxsplit=1 - zip() calls without strict -> zip(..., strict=False) - maasapiserver/tls.py: sync with uvicorn 0.38 lifespan API; replace _get_upgrade()/_should_upgrade_to_ws() with _should_upgrade(); add MUST_CLOSE guard to EndOfMessage handler - provisioningserver/logger/_twisted.py: extend __module__ check to accept _py_warnings for CPython 3.14 - maas_api_helper.py: wrap HTTPResponse in contextlib.closing to fix resource leak
r00ta
reviewed
Apr 1, 2026
Contributor
r00ta
left a comment
r00ta
left a comment
There was a problem hiding this comment.
question inline. The rest looks good
r00ta
approved these changes
Apr 2, 2026
alexsander-souza
merged commit f6ddaad
into
canonical:resolute_support
1 of 2 checks passed
alexsander-souza
added a commit
that referenced
this pull request
Apr 8, 2026
…hon 3.14 (#81) Address runtime warnings and errors surfaced by the Python 3.14 and dependency upgrades. - asyncio.iscoroutinefunction removed in 3.12 -> inspect.iscoroutinefunction - re.split positional maxsplit -> keyword argument maxsplit=1 - zip() calls without strict -> zip(..., strict=False) - maasapiserver/tls.py: sync with uvicorn 0.38 lifespan API; replace _get_upgrade()/_should_upgrade_to_ws() with _should_upgrade(); add MUST_CLOSE guard to EndOfMessage handler - provisioningserver/logger/_twisted.py: extend __module__ check to accept _py_warnings for CPython 3.14 - maas_api_helper.py: wrap HTTPResponse in contextlib.closing to fix resource leak
alexsander-souza
added a commit
that referenced
this pull request
Apr 8, 2026
…hon 3.14 (#81) Address runtime warnings and errors surfaced by the Python 3.14 and dependency upgrades. - asyncio.iscoroutinefunction removed in 3.12 -> inspect.iscoroutinefunction - re.split positional maxsplit -> keyword argument maxsplit=1 - zip() calls without strict -> zip(..., strict=False) - maasapiserver/tls.py: sync with uvicorn 0.38 lifespan API; replace _get_upgrade()/_should_upgrade_to_ws() with _should_upgrade(); add MUST_CLOSE guard to EndOfMessage handler - provisioningserver/logger/_twisted.py: extend __module__ check to accept _py_warnings for CPython 3.14 - maas_api_helper.py: wrap HTTPResponse in contextlib.closing to fix resource leak
alexsander-souza
added a commit
that referenced
this pull request
Apr 9, 2026
…hon 3.14 (#81) Address runtime warnings and errors surfaced by the Python 3.14 and dependency upgrades. - asyncio.iscoroutinefunction removed in 3.12 -> inspect.iscoroutinefunction - re.split positional maxsplit -> keyword argument maxsplit=1 - zip() calls without strict -> zip(..., strict=False) - maasapiserver/tls.py: sync with uvicorn 0.38 lifespan API; replace _get_upgrade()/_should_upgrade_to_ws() with _should_upgrade(); add MUST_CLOSE guard to EndOfMessage handler - provisioningserver/logger/_twisted.py: extend __module__ check to accept _py_warnings for CPython 3.14 - maas_api_helper.py: wrap HTTPResponse in contextlib.closing to fix resource leak
alexsander-souza
added a commit
that referenced
this pull request
Apr 17, 2026
…hon 3.14 (#81) Address runtime warnings and errors surfaced by the Python 3.14 and dependency upgrades. - asyncio.iscoroutinefunction removed in 3.12 -> inspect.iscoroutinefunction - re.split positional maxsplit -> keyword argument maxsplit=1 - zip() calls without strict -> zip(..., strict=False) - maasapiserver/tls.py: sync with uvicorn 0.38 lifespan API; replace _get_upgrade()/_should_upgrade_to_ws() with _should_upgrade(); add MUST_CLOSE guard to EndOfMessage handler - provisioningserver/logger/_twisted.py: extend __module__ check to accept _py_warnings for CPython 3.14 - maas_api_helper.py: wrap HTTPResponse in contextlib.closing to fix resource leak
alexsander-souza
added a commit
that referenced
this pull request
Apr 17, 2026
…hon 3.14 (#81) Address runtime warnings and errors surfaced by the Python 3.14 and dependency upgrades. - asyncio.iscoroutinefunction removed in 3.12 -> inspect.iscoroutinefunction - re.split positional maxsplit -> keyword argument maxsplit=1 - zip() calls without strict -> zip(..., strict=False) - maasapiserver/tls.py: sync with uvicorn 0.38 lifespan API; replace _get_upgrade()/_should_upgrade_to_ws() with _should_upgrade(); add MUST_CLOSE guard to EndOfMessage handler - provisioningserver/logger/_twisted.py: extend __module__ check to accept _py_warnings for CPython 3.14 - maas_api_helper.py: wrap HTTPResponse in contextlib.closing to fix resource leak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address runtime warnings and errors surfaced by the Python 3.14 and dependency upgrades.