Enable Format Flags for List#102
Conversation
wolsen
left a comment
There was a problem hiding this comment.
Thanks for the PR @kyzrfranz! This PR feels like it should be multiple commits as there's at least 2 distinct changes in here (list available disks, add format flags).
In addition it'd be great to see some test coverage for new functionality.
|
|
||
| import ( | ||
| "context" | ||
| "github.com/lxc/lxd/shared/i18n" |
There was a problem hiding this comment.
The order of the imports should be revisited. The convention for the repository is:
built-in
external imports
internal imports (github.com/canonical/microceph/XYZ in this case)
|
Hey, I've been looking into adding tests and it feels like this will cause some refactoring. The calls So - I could make a suggestion, but it would affect a lot of code. There may also be a quick & hacky way, but I'm not particularly keen on going there.. |
Since automation is one of the things I'm currently working on, I realised that the
listcommands don't make use of the formatting. I realise that's due to the fact that the output combines two sets of data essentially, that's not quite straightforward to put into one set.So the suggestion would be to:
list-a|--availablethat shows only locally available, unconfigured diskshope this is feasible.