fix: add checks before adding OSD, WAL, or DB devices#588
Merged
sabaini merged 4 commits intocanonical:mainfrom Jul 24, 2025
Merged
fix: add checks before adding OSD, WAL, or DB devices#588sabaini merged 4 commits intocanonical:mainfrom
sabaini merged 4 commits intocanonical:mainfrom
Conversation
This refactors the OSD management code by introducing an OSDManager struct that encapsulates OSD operations: - Create OSDManager with configurable dependencies (filesystem, runner, storage, validator) - Replace direct filesystem calls with afero.Fs interface for better testing - Add PathValidator interface to abstract block device path validation - Introduce StorageInterface to mock storage operations in tests - Convert standalone functions to OSDManager methods for better encapsulation - Add testing New dep: github.com/spf13/afero Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Also add unit tests to various OSD mgr methods Fixes: canonical#507 Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
lmlg
reviewed
Jul 23, 2025
Also make GetFileStat mock-able and fix mocking for devices Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Collaborator
Author
|
Thanks @lmlg care to take a look again? |
lmlg
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add checks for mounted devices and partitions. Also add/update some unit tests
Fixes: #507
Type of change
Delete options that are not relevant.
How has this been tested?
Unit tests
Contributor checklist
Please check that you have: