feat: add stripingv2 to default rbd featureset#650
Merged
sabaini merged 5 commits intocanonical:mainfrom Nov 24, 2025
Merged
Conversation
Add stripingv2 to the rbd features enabled by default. Client kernels > 5.3 should be ok with this. Add some docs for older clients on how to downgrade rbd features in case of incompat. Add tests, refactor a bit. Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
lmlg
reviewed
Nov 21, 2025
| // 63 = layering + exclusive-lock + object-map + fast-diff + deep-flatten + stripingv2 | ||
| err = SetConfigItem(apiTypes.Config{ | ||
| Key: "rbd_default_features", | ||
| Value: "63", |
Contributor
There was a problem hiding this comment.
I'm generally OK with these changes, but I wanted to know first how you reached the magic number 63, and whether it's a stable value or if we have to maintain different constants for different Ceph versions.
Collaborator
Author
There was a problem hiding this comment.
Ack, added some comments
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
skoech
reviewed
Nov 22, 2025
|
|
||
| $ sudo rbd feature disable block_pool/bd_foo object-map fast-diff deep-flatten | ||
|
|
||
| To change the default behaviour for the cluster, you can update the ``rbd_default_features`` config option: |
Collaborator
There was a problem hiding this comment.
Here (and in a few sections below), I'd suggest a bit more authoritative language, i.e. remove the "you can" to give users more confidence and direction/not feel like there are other options to consider (unless there are).
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
skoech
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add stripingv2 to the rbd features enabled by default. Client kernels > 5.3 should be ok with this. Add some docs for older clients on how to downgrade rbd features in case of incompat.
Add tests, refactor a bit.
Type of change
Delete options that are not relevant.
How has this been tested?
Updated unit test, add functest verif.
Contributor checklist
Please check that you have: