LXD: Don't set RBD features if not necessary#1282
Merged
Merged
Conversation
roosterfish
force-pushed
the
no_ceph_rbd_features
branch
from
74da5cb to
d4021d2
Compare
tomponline
previously approved these changes
Mar 17, 2026
roosterfish
force-pushed
the
no_ceph_rbd_features
branch
3 times, most recently
from
1198439 to
3ca2b8a
Compare
Contributor
Author
|
The two upgrade tests are expected to fail until #1281 is merged. |
roosterfish
force-pushed
the
no_ceph_rbd_features
branch
from
3ca2b8a to
19ad177
Compare
There was a problem hiding this comment.
Pull request overview
Updates MicroCloud’s Ceph storage-pool configuration and validation to align with newer LXD behavior (canonical/lxd#17890), where explicit RBD feature settings may be unnecessary.
Changes:
- Make
DefaultCephStoragePoolconditionally setceph.rbd.featuresbased on LXD’sstorage_ceph_use_rbd_defaultsAPI extension. - Update callers to handle the new
(*api.StoragePoolsPost, error)return signature. - Adjust upgrade tests to optionally skip asserting
ceph.rbd.featuresduring post-upgrade validation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/suites/upgrade.sh | Sets SKIP_CEPH_RBD_FEATURES=1 when validating upgraded clusters. |
| test/includes/microcloud.sh | Makes Ceph RBD feature assertion conditional (and skippable) during validation. |
| service/lxd_config.go | Stops forcing ceph.rbd.features when LXD supports using RBD defaults; changes function signature. |
| cmd/microcloud/preseed.go | Adapts preseed generation to the new DefaultCephStoragePool signature. |
| cmd/microcloud/ask.go | Adapts interactive init flow to the new DefaultCephStoragePool signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…LXD version Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Allow the upgrade test suite to bypass this to accommodate an older version of LXD with an already existing pool that has the ceph.rbd.features config key set naturally. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
no_ceph_rbd_features
branch
from
19ad177 to
afff0cf
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accommodate canonical/lxd#17890 in MicroCloud.