Revert scheduled tests with 2/candidate#1318
Conversation
2/candidate2/candidate
tugbataluy
left a comment
There was a problem hiding this comment.
LGTM. I missed the non-interactive binary dependency when approving #1315, apologies.
I should have spotted it beforehand. Before we can enable this we need to make sure we can test with arbitrary snap versions without injecting a custom test binary that accommodates the test suite. IIRC back then this wasn't added to the snap's binary to ensure the trust establishment cannot be shortcut as setting |
| # Don't inject debug binaries if not using the edge channel of MicroCloud. | ||
| # This allows running the test suite with candidate channels without injecting another version. | ||
| if [ -n "${MICROCLOUD_DEBUG_PATH}" ] && [ -n "${MICROCLOUDD_DEBUG_PATH}" ] && [[ "${MICROCLOUD_SNAP_CHANNEL}" == */edge ]]; then | ||
| if [ -n "${MICROCLOUD_DEBUG_PATH}" ] && [ -n "${MICROCLOUDD_DEBUG_PATH}" ]; then |
There was a problem hiding this comment.
Would it be possible to MICROCLOUD_DEBUG_PATH=/snap/microcloud/current/...?
This would sideload the same binary as shipped by the snap.
There was a problem hiding this comment.
Great idea, but the binary in the snap doesn't contain the bits that allow it being put into testing mode (not built with -tags=test).
If grabbing the random passphrase from stdout is feasible, that sounds like the best way forward to me. |
Actually this is how we did it from the start when adding trust establishment. But later we removed those bits from the binary which is shipped with the snap. |
This PR reverts #1315.
By simply skipping the binary injection for
2/candidate, we don't anymore use the special test binary required for the test suite that runs in non-interactive mode. This will cause the tests to error as allmicrocloud *commands will launch in interactive mode.As an example see https://github.com/canonical/microcloud/actions/runs/24138613221/job/70433996098.