service: Support latest MicroCeph tentacle#1338
service: Support latest MicroCeph tentacle#1338roosterfish wants to merge 6 commits intocanonical:mainfrom
Conversation
df57838 to
d75e7aa
Compare
There was a problem hiding this comment.
Pull request overview
Updates MicroCloud’s service version validation to accept the latest MicroCeph “tentacle” (newer major Ceph versions) rather than rejecting them.
Changes:
- Adjust MicroCeph version parsing/validation to use the shared
compareVersionlogic (allowing versions newer than the minimum). - Update version validation tests to treat a newer-major MicroCeph/Ceph version as supported.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| service/version.go | Switch MicroCeph validation to extract a semantic version from the daemon string and validate it via compareVersion. |
| service/version_test.go | Update test coverage to assert newer-major MicroCeph/Ceph versions are supported. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d75e7aa to
e29e73b
Compare
877a156 to
a891c47
Compare
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
a891c47 to
fe98e21
Compare
MicroCeph tentacle uses Microcluster v3 which uses the control unix socket to serve the SQL endpoint. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
snap tends to perform a retry itself. Also due to current state of runners retrying might not anymore be required. The retry call is still left for apt operations. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
|
The upgrade test on 22.04 fails due to MicroCeph tentacle. LXD cannot start the CephFS storage pool:
It works with 24.04 so likely kernel related. There also is a similar report here lxc/incus#2748. |
MicroCeph tentacle doesn't play nicely on 22.04 which causes upgrade test failures in #1338. Therefore let's pin MicroCeph squid edge for now to unblock the many other PRs waiting to be included (also in preparation to release another version of MicroCloud 2 for future LXD 6.8 support). Also ensure latest version of snapd to not get into conflicts when trying to install `core26`.
Support latest MicroCeph tentacle.