Use both IPv4 and IPv6 chosen addresses for default DNS addresses #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r DNS Additionally, it moves the DNS question after asking both IPv4 and IPv6 questions, as having it in the middle feels awkward. Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
masnax
requested review from
markylaing,
roosterfish and
tomponline
as code owners
roosterfish
approved these changes
Mar 18, 2024
|
|
||
| gateways := []string{} | ||
| for gateway := range ipConfig { | ||
| gatewayAddr, _, err := net.ParseCIDR(gateway) |
Contributor
There was a problem hiding this comment.
Why do you run net.ParseCIDR here? Is it for the purpose of validating that the gateway is valid? I think the validation is already done in the step before when invoking AskString.
Below you again get the string from the net.IP and append it to the list of gateways. So could you just take the gateway from the map and append it to the list?
Contributor
There was a problem hiding this comment.
Nevermind, you want to extract the IP only without the subnetmask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things: