System tests misc improvements #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
simondeziel
force-pushed
the
system-tests-misc-improvements
branch
3 times, most recently
from
71506c8 to
305c796
Compare
simondeziel
force-pushed
the
system-tests-misc-improvements
branch
4 times, most recently
from
3ea1371 to
a7e9f59
Compare
…s functions Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Since various snap edge channels are used, it makes sense to test them more often than on PRs against MicroCloud itself. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
This reverts commit a827156. As pointed out by Max, `rm -rf /foo/*/*` is just emptying all the subdirectories so it is not equivalent to `rm -rf /foo/*`. Reported-by: Max Asnaashari <max.asnaashari@canonical.com> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
This was pointless because `reset_systems` is always called at the begining of each test. Reported-by: Max Asnaashari <max.asnaashari@canonical.com> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
We initially intend to test against LXD latest/edge so don't warn about it. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…vmode Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…ph,ovn} snaps Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
latest/edge uses core24 and other latest/* are not a valid channels. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…anups Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
With output comparison, `set -x` output is easier to understand as we know both sides of the comparison. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
canonical#286 Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
force-pushed
the
system-tests-misc-improvements
branch
from
a7e9f59 to
5c536bd
Compare
simondeziel
requested review from
markylaing,
masnax,
roosterfish and
tomponline
as code owners
Member
Author
|
@masnax I know we agreed one splitting the interactive one even more but since I got a full green run, is that OK if we merge it as-is? |
masnax
approved these changes
Apr 24, 2024
Contributor
masnax
left a comment
masnax
left a comment
There was a problem hiding this comment.
Yay! All green :)
I'll have another PR coming up in a sec that will reorder the runners and log lxc info --resources plus a few other workarounds for issues I faced locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.