-
Notifications
You must be signed in to change notification settings - Fork 65
Update microcluster & microceph dependencies #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
roosterfish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There are some commits that include changes from other packages too but I guess as long as we don't need to backport stuff we can ignore this for now.
|
@gabrielmougard Got any idea what's going on with the add test? I find it odd that it's failing now since it seems unrelated to this PR. Looks like the cluster network isn't being set on the OSD config. Weird thing is I can't seem to reproduce the issue locally on my end. https://github.com/canonical/microcloud/actions/runs/9492146264/job/26160759670?pr=320#step:13:1548 |
|
That's weird indeed. Taking a look |
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
MicroCloud doesn't yet need any API extensions. Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
|
@roosterfish Alright, tests are passing again so it needs another approval, thanks :) |
Good news! Was it just another race in the test suite? |
No description provided.