Skip to content

Conversation

@masnax
Copy link
Contributor

@masnax masnax commented Jun 12, 2024

No description provided.

Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
roosterfish
roosterfish previously approved these changes Jun 12, 2024
Copy link
Contributor

@roosterfish roosterfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There are some commits that include changes from other packages too but I guess as long as we don't need to backport stuff we can ignore this for now.

@masnax
Copy link
Contributor Author

masnax commented Jun 13, 2024

@gabrielmougard Got any idea what's going on with the add test? I find it odd that it's failing now since it seems unrelated to this PR.

Looks like the cluster network isn't being set on the OSD config. Weird thing is I can't seem to reproduce the issue locally on my end.

https://github.com/canonical/microcloud/actions/runs/9492146264/job/26160759670?pr=320#step:13:1548

@gabrielmougard
Copy link
Contributor

That's weird indeed. Taking a look

masnax added 4 commits June 13, 2024 17:41
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
MicroCloud doesn't yet need any API extensions.

Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
@masnax
Copy link
Contributor Author

masnax commented Jun 13, 2024

@roosterfish Alright, tests are passing again so it needs another approval, thanks :)

@roosterfish
Copy link
Contributor

@roosterfish Alright, tests are passing again so it needs another approval, thanks :)

Good news! Was it just another race in the test suite?

@masnax masnax merged commit bf6a0bd into canonical:main Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants